This repository has been archived by the owner on Dec 15, 2022. It is now read-only.
♿️ Restore platform-centric menu names for showing in file manager #1311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lee-dohm
reviewed
Apr 17, 2019
lib/tree-view.coffee
Outdated
| @@ -560,13 +560,22 @@ class TreeView | |||
| return unless filePath = @selectedEntry()?.getPath() | |||
|
|
|||
| unless shell.showItemInFolder(filePath) | |||
| atom.notifications.addWarning("Unable to show #{filePath} in file manager") | |||
| atom.notifications.addWarning("Unable to show #{filePath} in #{@getFileManagerName().toLowerCase()}") | |||
There was a problem hiding this comment.
We should probably leave the case unmodified here.
Suggested change
| atom.notifications.addWarning("Unable to show #{filePath} in #{@getFileManagerName().toLowerCase()}") | |
| atom.notifications.addWarning("Unable to show #{filePath} in #{@getFileManagerName()}") |
lee-dohm
reviewed
Apr 17, 2019
lib/tree-view.coffee
Outdated
|
|
||
| showCurrentFileInFileManager: -> | ||
| return unless filePath = atom.workspace.getCenter().getActiveTextEditor()?.getPath() | ||
|
|
||
| unless shell.showItemInFolder(filePath) | ||
| atom.notifications.addWarning("Unable to show #{filePath} in file manager") | ||
| atom.notifications.addWarning("Unable to show #{filePath} in #{@getFileManagerName().toLowerCase()}") |
There was a problem hiding this comment.
We should probably leave the case unmodified here.
Suggested change
| atom.notifications.addWarning("Unable to show #{filePath} in #{@getFileManagerName().toLowerCase()}") | |
| atom.notifications.addWarning("Unable to show #{filePath} in #{@getFileManagerName()}") |
|
Thanks @mattlubner!
No need to build Atom locally, you can follow this guide to link your modified version of tree view: https://flight-manual.atom.io/hacking-atom/sections/contributing-to-official-atom-packages/ I confirmed that tests aren't necessary in this case but it would be good if you can manual verify that things look ok on Windows, macOS, and Linux with your changes. |
|
Thanks! |
1 task
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
Addresses #1307. Restore platform-centric menu names for showing files in the user's file manager.
Benefits
Possible Drawbacks
shell.showItemInFolderopens a third-party file manager.Applicable Issues